Fix moved_records not cleaned #1076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 4, 2024 00:07
… to make sure events remove after they can be used as a "source". Dict content changed from holding whole event to hold only src_path and time, since only src_path is used, time added to use it as a threshold to clean.
Extra test folder deleted On branch fix_moved_records_not_cleaned Changes to be committed: modified: src/watchdog/observers/inotify_c.py modified: tests/test_inotify_c.py deleted: tests/threaded/conftest.py deleted: tests/threaded/test_inotify_c.py
Changes to be committed: modified: src/watchdog/observers/inotify_c.py
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added separate thread to clean records from moved_events that are used for source_path acquisition with some delay for events not to get cleaned before they have a chance to be used as for source_path acquisition
Dict optimized to hold smaller object with only src_path and timestamp.
This PR supposed to deal with #1041
And possibly partly with #587