Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: md5sums entries and lintian errors/warnings #656

Merged
merged 1 commit into from
May 11, 2023

Conversation

malaupa
Copy link
Contributor

@malaupa malaupa commented May 11, 2023

  • Missing trailing ./ in md5sums for changelog.Debian.gz caused md5sums-lists-nonexistent-file and file-missing-in-md5sums and is fixed using files.AsExplicitRelativePath.
  • Adding copyright file fixes no-copyright-file.
  • Set file_info fixes executable-is-not-world-readable, non-standard-executable-perm, non-standard-file-perm.
  • Adding section fixes unknown-section, empty-field.
  • Using standard compress/gzip module fixes package-contains-timestamped-gzip, because klauspost/pgzip does not support empty mod time.
  • Adding urgency and distribution in changelog fixes syntax-error-in-debian-changelog.
  • Adding mail address to maintainer fixes malformed-contact.
  • Correcting description fixes description-starts-with-package-name and description-starts-with-leading-spaces.

Missing trailing ./ in md5sums for changelog.Debian.gz caused
md5sums-lists-nonexistent-file and file-missing-in-md5sums
and is fixed using files.AsExplicitRelativePath.
Adding copyright file fixes no-copyright-file.
Set file_info fixes executable-is-not-world-readable,
non-standard-executable-perm, non-standard-file-perm.
Adding section fixes unknown-section, empty-field.
Using standard compress/gzip module fixes
package-contains-timestamped-gzip,
because klauspost/pgzip does not support empty mod time.
Adding urgency and distribution in changelog fixes
syntax-error-in-debian-changelog.
Adding mail address to maintainer fixes malformed-contact.
Correcting description fixes description-starts-with-package-name
and description-starts-with-leading-spaces.
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #656 (36cd731) into main (a1fb047) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   75.68%   75.71%   +0.02%     
==========================================
  Files          14       14              
  Lines        2941     2944       +3     
==========================================
+ Hits         2226     2229       +3     
  Misses        506      506              
  Partials      209      209              
Impacted Files Coverage Δ
deb/deb.go 71.51% <75.00%> (+0.17%) ⬆️

@caarlos0 caarlos0 merged commit b1f3fef into goreleaser:main May 11, 2023
@caarlos0
Copy link
Member

awesome, thank you!

@github-actions github-actions bot added this to the v2.27.0 milestone May 11, 2023
@caarlos0 caarlos0 modified the milestones: v2.27.0, v2.29.0 Sep 12, 2023
@caarlos0 caarlos0 added the bug Something isn't working label Sep 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants