Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Doc fix for testing variables in path #374

Merged
merged 1 commit into from
May 13, 2018
Merged

Conversation

swalberg
Copy link
Contributor

The example in the README does not pass the request through a mux therefore the request variables from the path are never populated. Update the sample to create a minimum viable router to use.

Fixes #373

The example in the README does not pass the request through a mux therefore the request variables from the path are never populated. Update the sample to create a minimum viable router to use.

Fixes gorilla#373
@elithrar
Copy link
Contributor

Thanks for this @swalberg.

We'd eventually like to make our README examples testable via something like embedmd, which will help address this.

@elithrar elithrar closed this May 13, 2018
@elithrar elithrar reopened this May 13, 2018
@elithrar elithrar merged commit fdeb7bc into gorilla:master May 13, 2018
@swalberg swalberg deleted the patch-1 branch May 13, 2018 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants