-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Drop support for Go < 1.7: remove gorilla/context #391
Conversation
You’ll need to:
|
Alright. Also, I'm not sure, but it seems like we can remove contextClear from context_native and the code block from mux.go 158:160. If we did that |
Actually gorilla/context is required. |
@fharding1 Did you want to make the adjustment here as per @flibustenet's comment? |
I'm not sure what he means, why is it required? |
It would provide Module support before the change.
I don’t think it’s explicitly required, but I hadn’t seem acknowledgement
either way.
…On Tue, Aug 28, 2018 at 7:18 AM Franklin Harding ***@***.***> wrote:
I'm not sure what he means, why is it required?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#391 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABIcKq7tfJXNlyJiZ29grEXjcU_kwf7ks5uVVEdgaJpZM4VIfhX>
.
|
I'm not super familiar with modules, but yeah, I don't think it's required. Wasn't planning on addressing that feedback unless @flibustenet can clarify why it's required. |
I was just thinking of the historical side. We could see it was required and not after. But the changelog is ok also, nothing more... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor build & filename adjustments required, otherwise a straightforward change!
3615587
to
59ccdf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fharding1
Remove gorilla/context for reasons outlined in issue #326.