-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[WIP] Create CircleCI config #484
Conversation
PS: Don't merge, this is a WIP / demo / validating whether it's worth migrating to. |
My $0.02: I've used CircleCI for a few projects and have had nothing but good experiences. Simple configuration, decent build time, and used widely enough for most people to be somewhat familiar with it. Then again, I could say most of those things for Travis :) 👍 moving to CircleCI |
Istio, et. al using it also inspire a bit of confidence. I'm going to leave this open for the time being - I also need to think about moving all Gorilla projects over (not just one) as part of this. |
Some initial explorations around DRY'ing the config, at the expense of workflow/status visibility - which isn't a worthwhile trade-off, IMO - https://gist.github.com/elithrar/4fa799c66b2c9932ac33f450f0787a58 The thing I'm mostly trying to solve for is versioning - I want it to be easy to run multiple versions (since we do so for backwards-compat!) and minimize human error when it comes to writing the CI config itself. |
Going to merge and let co-exist with TravisCI for a while. Next steps would be to:
I'm also using this for another OSS project I'm about to release - to both test the library & build a container image - and the flexibility definitely pays off more there. |
Would also be nice if the CircleCI script could somehow pick up new versions of Go into the build matrix. I'm not sure if that's possible or not, but that was always a maintenance headache with the travis config. |
For posterity: the script used to generate PRs were still manual; those are next to automate - likely by traversing the repos under |
Validate CircleCI.