Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(mux.go): use cleaned path as URL.Path #674

Closed
wants to merge 2 commits into from
Closed

fix(mux.go): use cleaned path as URL.Path #674

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38fa650
fix(mux.go): use cleaned path as URL.Path
with-shrey May 2, 2022
33706bf
Merge branch 'main' into 673-wrong-http-method
coreydaley Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions mux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,19 +179,7 @@ func (r *Router) ServeHTTP(w http.ResponseWriter, req *http.Request) {
path = req.URL.EscapedPath()
}
// Clean path to canonical form and redirect.
if p := cleanPath(path); p != path {

// Added 3 lines (Philip Schlump) - It was dropping the query string and #whatever from query.
// This matches with fix in go 1.2 r.c. 4 for same problem. Go Issue:
// http://code.google.com/p/go/issues/detail?id=5252
url := *req.URL
url.Path = p
p = url.String()

w.Header().Set("Location", p)
w.WriteHeader(http.StatusMovedPermanently)
return
}
req.URL.Path = cleanPath(path)
}
var match RouteMatch
var handler http.Handler
Expand Down