Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ci): rework get latest tag for build Docker image #954

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

dklimpel
Copy link
Contributor

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

I have seen that building the Docker image had failed: https://github.com/goss-org/goss/actions/runs/9982852891/job/27589357250

Reason is a not fixed upstream bug. actions-ecosystem/action-get-latest-tag#22
I was not able to reproduce this in my fork.

I have reworked this part of CI:

  • only run to get the tag if required
  • remove the dependency. this does not seem to be well maintained
  • apply the fix from the PR

@aelsabbahy
Copy link
Member

I'll merge this now. I can either cut a release to test.. or if we're close to switching over to GHA, I can cut a release using GHA and test all of it at once

@aelsabbahy aelsabbahy merged commit 1215fce into goss-org:master Aug 1, 2024
5 checks passed
@dklimpel dklimpel deleted the rework_get_latest_tag branch August 1, 2024 20:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants