Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Add Hamburger Menu & Loader HOC #168

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

PhillipUg
Copy link

Description

Optimize the header to display well on small screens

  • Currently, the top navigation is the same for all screen sizes. When seen on small screens the nav items wrap in an uncomfortable way.
  • To fix this i modify the header to show the nav items in a dropdown hamburger menu when the screen size is below 768px
  • The hamburger button is aligned to the left side of the screen.

Use of the HOC pattern to implement a better loading state

  • I create a Loader component as a Higher Order Component which replaces the "Loading..." message that appears as you navigate/refresh the article pages.
  • The loading state is now indicated by a spinner animation (Using react-spinners library by David Hu)

@PhillipUg PhillipUg changed the title Hamburger Menu & Loader HOC Add Hamburger Menu & Loader HOC Nov 20, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant