Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

images are handled throught the app #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ak2783934
Copy link

Since the images were not visible when not uploaded, I have changed it such that if you have an image, then it will go with the uploaded one, otherwise, it will show an emoji. I will help the app look better.

@cirosantilli
Copy link

cirosantilli commented Jun 25, 2021

This should likely be clarified on the master project first: https://github.com/gothinkster/realworld/issues to specify desired behaviour across all frontends. E.g. the "reference" implementation, which is Angular-based, simply shows omits the image if not set: https://react-redux.realworld.io/ e.g. in the navbar.

The matser of this project is however definitely broken whatever the decision there might be https://github.com/gothinkster/react-redux-realworld-example-app/tree/9186292054dc37567e707602a15a0884d6bdae35

Screenshot from 2021-06-25 12-33-56

The live website is however the same as angular, does not show image if not set: https://react-redux.realworld.io/#/?_k=yix5vw But extremely confusingly it shows the default image everywhere else except login. Likely showing the default smiley would be the way to go as you propose.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants