Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Have a look at your cmake_env.inc #99

Open
ghost opened this issue Jun 4, 2023 · 1 comment
Open

Have a look at your cmake_env.inc #99

ghost opened this issue Jun 4, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 4, 2023 •
edited by ghost
Loading

On MSYS2, CMAKE_SYSTEM_NAME is always Windows so your check for MSYS and MINGW32 will not work. You can use these variables instead:

https://cmake.org/cmake/help/latest/variable/MINGW.html

https://cmake.org/cmake/help/latest/variable/MSVC.html

https://cmake.org/cmake/help/latest/variable/WIN32.html

For Linux you still have to check with CMAKE_SYSTEM_NAME. Note: since cmake 3.25 you could use the variable LINUX.
@ghost ghost mentioned this issue Jun 4, 2023
Open
gozfree added a commit that referenced this issue Jul 23, 2023
@gozfree
[cmake] fix issue #99 #100, check mingw on window
01ad990
@gozfree
Copy link
Owner

gozfree commented Jul 23, 2023

yes, thanks for your help

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gozfree