Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Confusing methods naming #177

Closed
Bardin08 opened this issue Aug 22, 2021 · 2 comments · Fixed by #180
Closed

Confusing methods naming #177

Bardin08 opened this issue Aug 22, 2021 · 2 comments · Fixed by #180
Labels
enhancement
Milestone
1.10.0

Comments

@Bardin08
Copy link

Description:
The IMegaApiClient provides two methods: GetNodeFromLinkAsync and GetNodesFromLinkAsync. As a user, I expect both methods to return an instance(-s) of INode or INodeInfo.

Task<INodeInfo> GetNodeFromLinkAsync(Uri uri);
Task<IEnumerable<INode>> GetNodesFromLinkAsync(Uri uri);

Actual Behavior:
Now, GetNodeFromLinkAsync returns an instance of INodeInfo when GetNodesFromLinkAsync returns an IEnumerable.

Expected Behavior:
Both methods should return the same type, or one of them should be renamed.

MegaApiClient Version: 1.9.0 (NuGet)
@gpailler
Copy link
Owner

Hi thanks for your report. I will check to make GetNodeFromLinkAsync and GetNodesFromLinkAsync consistent

@gpailler gpailler added this to the vNext milestone Aug 25, 2021
gpailler added a commit that referenced this issue Sep 28, 2021
@gpailler
#177 Remove INodeInfo interface for API consistency (use INode as a d…
c6726b5 
…rop-in replacement)

- INode.SerializedFingerprint is renamed to INode.Fingerprint
- INode.CreationDate type is changed from DateTime to Nullable<DateTime>

+semver: minor
gpailler added a commit that referenced this issue Oct 2, 2021
@gpailler
#177 Remove INodeInfo interface for API consistency (#180)
74de4cc 
- INode is used instead of INodeInfo
- INode.SerializedFingerprint is renamed to INode.Fingerprint
- INode.CreationDate type is changed from DateTime to Nullable<DateTime>

+semver: minor
@gpailler gpailler linked a pull request Nov 5, 2021 that will close this issue
#177 Remove INodeInfo interface for API consistency #180
Merged
@gpailler
Copy link
Owner

1.10.0 released

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

#177 Remove INodeInfo interface for API consistency gpailler/MegaApiClient
2 participants
@gpailler @Bardin08