Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

api calls hanging #186

Merged
merged 3 commits into from
Nov 7, 2021
Merged

api calls hanging #186

merged 3 commits into from
Nov 7, 2021

Conversation

gpailler
Copy link
Owner

@gpailler gpailler commented Nov 5, 2021

#178 Fix API calls hangs by checking Tls12 support or enforce Tls12 depending of the target:

  • net40 : check that (SecurityProtocolType)3072 is specified
  • net45 : check that SecurityProtocolType.Tls12 is specified
  • net46 : check that SecurityProtocolType.Tls12 is specified
  • net47 (target added) : check that SecurityProtocolType.Tls12 or SecurityProtocolType.UseDefault is specified
  • net471 (target added) : force usage of Tls12 in HttpClient ctor
  • netstandard1.3 : force usage of Tls12 in HttpClient ctor
  • netstandard2.0 : force usage of Tls12 in HttpClient ctor

…epending of the target:

- net40 : check that (SecurityProtocolType)3072 is specified
- net45 : check that SecurityProtocolType.Tls12 is specified
- net46 : check that SecurityProtocolType.Tls12 is specified
- net47 (target added) : check that SecurityProtocolType.Tls12 or SecurityProtocolType.UseDefault is specified
- net471 (target added) : force usage of Tls12 in HttpClient ctor
- netstandard1.3 : force usage of Tls12 in HttpClient ctor
- netstandard2.0 : force usage of Tls12 in HttpClient ctor
@gpailler gpailler added this to the vNext milestone Nov 5, 2021
@gpailler gpailler self-assigned this Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #186 (bc1bffd) into master (3b6afeb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files          38       38           
  Lines        1722     1722           
  Branches      232      231    -1     
=======================================
  Hits         1420     1420           
  Misses        235      235           
  Partials       67       67           
Impacted Files Coverage Δ
MegaApiClient/WebClient_HttpClient.cs 94.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aefebc...bc1bffd. Read the comment docs.

# Conflicts:
#	MegaApiClient/MegaApiClient.csproj
@gpailler gpailler force-pushed the 178-api-calls-hanging branch from d198f15 to bc1bffd Compare November 5, 2021 13:54
@gpailler gpailler merged commit d6035cc into master Nov 7, 2021
@gpailler gpailler deleted the 178-api-calls-hanging branch November 7, 2021 12:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't login with e-mail & password, nor anonimously All calls to megaclient API hanging
1 participant