This repository has been archived by the owner on Mar 23, 2018. It is now read-only.
Fix cross-platform issues with getFiles() #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2017 12:40
It was discovered that getFiles() does not handle Windows paths very well. This patch addresses the issue by: 1. Ensuring the tests are cross-platform themselves 2. All input and output paths are properly normalized by using `path.normalize()` and `path.join()`. Signed-off-by: Hajime Yamasaki Vukelic <hayavuk@gmail.com>
Signed-off-by: Hajime Yamasaki Vukelic <hayavuk@gmail.com>
|
Awesome thanks! I can't publish the fix on npm right now as I'm traveling - I'll do it ASAP :) |
|
I'm just back from my trip – going to publish this soon! Thanks for the patience! |
|
@destroyerofbuilds Once this patch is published (if it isn't already), please try it and file a new issue if your issue persists. Mention me in the issue and I'll try to respond and fix it. |
|
Thanks @foxbunny for the help! Yes it is already published 👍🏽 |
ghost
mentioned this pull request
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that getFiles() does not handle Windows paths very well. This
patch addresses the issue by:
path.normalize()andpath.join().Issue originally reported in #24
NOTE: I haven't had a chance to test this on a non-Windows computer yet.
Signed-off-by: Hajime Yamasaki Vukelic hayavuk@gmail.com