Skip to content

Fix: move getting trigger time after io calls #264

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

S1ro1
Copy link
Collaborator

@S1ro1 S1ro1 commented Apr 28, 2025

EDIT: need one fix, will check tomorrow, this doesn't break anything unless like ~10-15 people submit at the same time

@Copilot Copilot AI review requested due to automatic review settings April 28, 2025 14:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ordering of the trigger time assignment to occur after the workflow dispatch IO call, ensuring that the recorded trigger time accurately reflects when the workflow was dispatched.

  • Moved the assignment of trigger_time from before the IO call to immediately after dispatching the workflow.
Comments suppressed due to low confidence (1)

src/discord-cluster-manager/launchers/github.py:174

  • [nitpick] Consider adding a comment to explain why trigger_time is now captured after the workflow dispatch IO call, clarifying the rationale for this change.
trigger_time = datetime.datetime.now(datetime.timezone.utc)

@msaroufim msaroufim self-requested a review April 28, 2025 15:37
@S1ro1 S1ro1 marked this pull request as draft April 28, 2025 23:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants