Skip to content

op: Add 'color_write_mask,blending_disabled' to blending.spec.ts #1994

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

Gyuyoung
Copy link
Collaborator

@Gyuyoung Gyuyoung commented Nov 17, 2022

This PR adds a new test to ensure that the color write mask works when blending is disabled.

Issue: #1835


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

Previews, as seen when this build job started (7d343b9):
Run tests | View tsdoc

@Gyuyoung Gyuyoung requested a review from kainino0x November 17, 2022 19:02
@Gyuyoung Gyuyoung marked this pull request as ready for review November 17, 2022 19:23
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test code LGTM

This PR adds a new test to ensure that color write mask works when blending is disabled.

Issue: gpuweb#1835
@Gyuyoung Gyuyoung force-pushed the color-write-mask-blending-disabled branch from 7d343b9 to eb3ed61 Compare November 20, 2022 02:54
@github-actions
Copy link

Previews, as seen when this build job started (eb3ed61):
Run tests | View tsdoc

@kainino0x kainino0x enabled auto-merge (squash) November 21, 2022 23:22
@kainino0x kainino0x merged commit 21a8e06 into gpuweb:main Nov 21, 2022
@github-actions
Copy link

Previews, as seen when this build job started (cf15966):
Run tests | View tsdoc

@Gyuyoung Gyuyoung deleted the color-write-mask-blending-disabled branch November 22, 2022 00:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants