Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Laravel 10.x Compatibility #31

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-sms-api.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "gr8shivam/laravel-sms-api": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@mtawil
Copy link

mtawil commented Feb 28, 2023

Hey @gr8shivam,

Would you please have a look at this PR and merge it?

Thank you.

@mtawil
Copy link

mtawil commented Mar 4, 2023

@gr8shivam Any update?

@mtawil
Copy link

mtawil commented Mar 11, 2023

@gr8shivam Why it takes so long time to merge?

@gr8shivam gr8shivam merged commit 33bf673 into gr8shivam:master Mar 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants