Enable build support for JEP 493 enabled base JDKs #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JEP 493-enabled JDKs won't have a 'jmods' directory by default. For builds with option --no-jlinking the replacement of base JDK-provided non-upgradable modules is not required, nor desired. Allow for builds with no JMODs in that case by checking for this option being in use and if so upgrade the module path when compiling module-info.java files.
oracle-contributor-agreement
bot
added
the
OCA Verified
dougxc
reviewed
Nov 22, 2024
dougxc
reviewed
Nov 22, 2024
|
@dougxc Could you please take another look? Would something like that be acceptable? Thanks! |
jerboaa
added a commit
to jerboaa/graal
that referenced
this pull request
Nov 26, 2024
With JEP 493, part of JDK 24, it's possible to have JDK builds without the `jmods` folder. Currently substratevm builds assume `jmods` are always present. This patch adds an extension to mx so as to produce custom javac args when specific substratevm dependencies get compiled. All of this is activated only when `--no-jlinking` option is being used. This patch depends on (which adds the needed abstractions to mx): graalvm/mx#287
This was referenced Nov 26, 2024
dougxc
reviewed
Nov 26, 2024
jerboaa
added a commit
to jerboaa/graal
that referenced
this pull request
Nov 26, 2024
With JEP 493, part of JDK 24, it's possible to have JDK builds without the `jmods` folder. Currently substratevm builds assume `jmods` are always present. This patch adds an extension to mx so as to produce custom javac args when specific substratevm dependencies get compiled. All of this is activated only when `--no-jlinking` option is being used. This patch depends on (which adds the needed abstractions to mx): graalvm/mx#287
dougxc
approved these changes
Nov 26, 2024
Thank you! |
|
@dougxc Once integrated we'd also need a tagged mx version to pick it up in graal accordingly. Thanks! |
|
This merged as e262358. |
|
Thank you! |
jerboaa
added a commit
to jerboaa/graal
that referenced
this pull request
Nov 28, 2024
With JEP 493, part of JDK 24, it's possible to have JDK builds without the `jmods` folder. Currently substratevm builds assume `jmods` are always present. This patch adds an extension to mx so as to produce custom javac args when specific substratevm dependencies get compiled. All of this is activated only when `--no-jlinking` option is being used. This patch depends on (which adds the needed abstractions to mx): graalvm/mx#287
graalvmbot
pushed a commit
to oracle/graal
that referenced
this pull request
Dec 2, 2024
With JEP 493, part of JDK 24, it's possible to have JDK builds without the `jmods` folder. Currently substratevm builds assume `jmods` are always present. This patch adds an extension to mx so as to produce custom javac args when specific substratevm dependencies get compiled. All of this is activated only when `--no-jlinking` option is being used. This patch depends on (which adds the needed abstractions to mx): graalvm/mx#287
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JEP 493-enabled JDKs won't have a 'jmods' directory by default. For builds with option --no-jlinking the replacement of base JDK-provided non-upgradable modules is not required, nor desired. Allow for builds with no JMODs in that case by checking for this option being in use and if so upgrade the module path when compiling module-info.java files.
Tested with the following on a based JDK without
jmodsfolder:Closes #286