Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Cache checksums after they have been fetched #172

Closed
bigdaz opened this issue Apr 13, 2024 · 4 comments
Closed

Cache checksums after they have been fetched #172

bigdaz opened this issue Apr 13, 2024 · 4 comments
Labels
enhancement New feature or request in:wrapper-validation
Milestone
v4.0.0

Comments

@bigdaz
Copy link
Member

bigdaz commented Apr 13, 2024

Currently, if a checksum isn't in the "known" list, we fetch every time.
We could cache the results to avoid this unnecessary work.
@bgalek
Copy link

bgalek commented Apr 15, 2024

are you accepting contributions? :)

@bigdaz
Copy link
Member Author

bigdaz commented Apr 15, 2024

Yes PRs are always welcome!

@bigdaz
Copy link
Member Author

bigdaz commented Apr 15, 2024

@bgalek If you're diving into this area, it might be worth looking at #171 before this one.

@bgalek
Copy link

bgalek commented Apr 15, 2024

Perfect, I'll look into it!

@bigdaz bigdaz added enhancement New feature or request in:wrapper-validation labels Apr 17, 2024
@bigdaz bigdaz self-assigned this Jul 19, 2024
@bigdaz bigdaz mentioned this issue Jul 19, 2024
Closed
@bigdaz bigdaz removed their assignment Jul 19, 2024
bigdaz added a commit that referenced this issue Aug 1, 2024
@bigdaz
Cache validated checksums for later executions
6d2d43d 
The most common case for validation will be that the wrapper jars are unchanged
from a previous workflow run. In this case, we cache the validated wrapper
checksums to minimise the work required on a subsequent run.

Fixes #172
@bigdaz bigdaz closed this as completed in b6395da Aug 1, 2024
@bigdaz bigdaz added this to the v4.0.0 milestone Aug 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request in:wrapper-validation
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@bigdaz @bgalek