Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make gradle-home-cache-cleanup: true the default #26

Closed
martinbonnin opened this issue Mar 17, 2023 · 2 comments · Fixed by #303
Closed

Make gradle-home-cache-cleanup: true the default #26

martinbonnin opened this issue Mar 17, 2023 · 2 comments · Fixed by #303
Assignees
@bigdaz
Labels
enhancement New feature or request in:cache-cleanup
Milestone
v4.0.0

Comments

@martinbonnin
Copy link

Hi 👋 Thanks for saving our build times ❤️ Would it make sense to include gradle-home-cache-cleanup: true by default and have the option opt-out? Sounds like this would be a reasonable default to expect?
@martinbonnin martinbonnin mentioned this issue Mar 17, 2023
Merged
@ashdavies ashdavies mentioned this issue Mar 17, 2023
Merged
@bigdaz
Copy link
Member

bigdaz commented Mar 27, 2023

@martinbonnin Yes this is the plan longer term, but the cache-cleanup was released as "experimental" and I didn't feel ready to enable it by default. Enabling by default will be in an upcoming release.

@bigdaz bigdaz added the enhancement New feature or request label Mar 27, 2023
sschuberth referenced this issue in oss-review-toolkit/ort Jun 22, 2023
@sschuberth
ci(GitHub): Clean up the Gradle user home before caching
0c8b3d2 
See [1]. At a later point, this will become the default [2], and then
this could be reverted.

[1]: https://github.com/gradle/gradle-build-action#removing-unused-files-from-gradle-user-home-before-saving-to-cache
[2]: https://github.com/gradle/gradle-build-action/issues/630

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth sschuberth mentioned this issue Jun 22, 2023
Merged
sschuberth referenced this issue in oss-review-toolkit/ort Jun 22, 2023
@sschuberth
ci(GitHub): Clean up the Gradle user home before caching
4fbcd31 
See [1]. At a later point, this will become the default [2], and then
this could be reverted.

[1]: https://github.com/gradle/gradle-build-action#removing-unused-files-from-gradle-user-home-before-saving-to-cache
[2]: https://github.com/gradle/gradle-build-action/issues/630

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@bigdaz
Copy link
Member

bigdaz commented Aug 21, 2023 •
edited
Loading

Here are the current issues that need to be investigated/fixed prior to enabling gradle-home-cache-cleanup by default.

DONE:

@bigdaz bigdaz transferred this issue from gradle/gradle-build-action Feb 9, 2024
@bigdaz bigdaz mentioned this issue Apr 4, 2024
Closed
@bigdaz bigdaz self-assigned this Jul 15, 2024
@bigdaz bigdaz added this to the v4.0.0 milestone Jul 19, 2024
@bigdaz bigdaz mentioned this issue Jul 19, 2024
Merged
@bigdaz bigdaz closed this as completed in 12cb23c Jul 19, 2024
bigdaz added a commit that referenced this issue Jul 19, 2024
@bigdaz
Prepare for v4 release (#303)
8e4868a 
Resolves #297
Resolves #26
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bigdaz bigdaz

Labels
enhancement New feature or request in:cache-cleanup
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Prepare for v4 release gradle/actions
2 participants
@bigdaz @martinbonnin