Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only fetch checksums for unknown wrapper versions #292

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Jul 15, 2024

The checksum values for most wrapper versions are hard-coded into the action. These known checksum values are first used for validation: only if none of the known values work do we download checksums.

Previously, we blindly downloaded all of the checksum values in this case: we now only download the checksums for versions that are not in our "known" set.

Fixes #171

The checksum values for most wrapper versions are hard-coded into the action.
These known checksum values are first used for validation: only if none of the known
values work do we download checksums.

Previously, we blindly downloaded all of the checksum values in this case: we now only
download the checksums for versions that are not in our "known" set.

Fixes #171
@bigdaz bigdaz merged commit dff3ef9 into main Jul 16, 2024
120 checks passed
@bigdaz bigdaz deleted the dd/fetch-unknown-checksums branch July 16, 2024 19:04
@bigdaz bigdaz modified the milestones: v3.6.0, v4.0.0 Jul 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only fetch new versions when validating wrapper jars
1 participant