Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Renovate Bot] Update AGP versions (patch) #1751

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

bot-gh-dv-shared
Copy link
Collaborator

This PR contains the following updates:

Package Update Change
com.android.tools.build:gradle (source) patch 8.7.2 -> 8.7.3
com.android.tools.build:gradle (source) patch 8.8.0-beta01 -> 8.8.0
com.android.tools.build:gradle (source) patch 8.9.0-alpha04 -> 8.9.0-alpha09

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

gabrielfeo added a commit that referenced this pull request Jan 13, 2025
Since #1742, the `generate_versions` CI job [succeeds even though it
can't parse the JSON file][1]. Parsing fails because `jq` [doesn't
support JSON5][2]. The job succeeds silently despite this failure
because it's ran inside [command substitution][3]. This currently
results in #1751 not running proper tests.

Fix the `generate_versions` CI job to correctly parse the JSON5 file by
stripping comment lines before passing its content to `jq`. Also ensure
the job will fail if the step fails by running it once outside command
substitution and ensuring `pipefail` is on. This replaces the "debug"
step.

[1]:
https://github.com/gradle/android-cache-fix-gradle-plugin/actions/runs/12717112831
[2]: jqlang/jq#1571
[3]:
https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html
Signed-off-by: Renovate Bot for Gradle <bot-gh-dv-shared+renovate@gradle.com>
@gabrielfeo gabrielfeo force-pushed the renovate/patch-agp-versions branch from 510ef85 to cc223c2 Compare January 13, 2025 18:24
(cherry picked from commit 0d2e07e9cb3a078755e0678cc15df9fd6cce2b94)
@gabrielfeo gabrielfeo merged commit 6317609 into main Jan 14, 2025
21 checks passed
@gabrielfeo gabrielfeo deleted the renovate/patch-agp-versions branch January 14, 2025 12:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants