Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

uploadInBackground can be configured even Develocity plugin is already applied #36

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

erichaagdev
Copy link
Member

This PR allows the uploadInBackground setting to be configured even if the project already applies the Develocity plugin.

This is necessary for the Develocity Build Validation Scripts, but could also be useful for CI plugins.

Where this will change behavior for CI users is if the project is currently configuring uploadInBackground = true on CI. The CI plugins disable this if configured to do so.

@erichaagdev erichaagdev requested a review from bigdaz February 5, 2025 19:50
@erichaagdev erichaagdev self-assigned this Feb 5, 2025
@erichaagdev erichaagdev force-pushed the erichaagdev/upload-in-background branch from 09f6696 to 6655235 Compare February 5, 2025 20:47
@erichaagdev erichaagdev force-pushed the erichaagdev/upload-in-background branch from 6655235 to a3a90cd Compare February 5, 2025 20:51
Copy link
Member

@bigdaz bigdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigdaz bigdaz merged commit fa53c66 into main Feb 5, 2025
1 check passed
@bigdaz bigdaz deleted the erichaagdev/upload-in-background branch February 5, 2025 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants