Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fail build step if Gradle version does not support dependency graph generation #1034

Closed
bigdaz opened this issue Jan 12, 2024 · 0 comments · Fixed by #1036
Closed

Fail build step if Gradle version does not support dependency graph generation #1034

bigdaz opened this issue Jan 12, 2024 · 0 comments · Fixed by #1036
Milestone

Comments

@bigdaz
Copy link
Member

bigdaz commented Jan 12, 2024

If the primary purpose of a workflow is to generate and submit a dependency graph, then the workflow should fail if this isn't achieved. Presently, the behaviour is to warn and continue.

We could add an option like dependency-graph-continue-on-failure that defaults to true (for now), but can be switched to false so that Gradle version and permission issues cause the workflow to fail, rather than simply warning.

@bigdaz bigdaz added this to the 3.0.0 milestone Jan 12, 2024
bigdaz added a commit that referenced this issue Jan 13, 2024
One goal for the original dependency-graph support was to minimize it's
impact on existing workflows, by operating transparently and not
impacting the build outcome. This meant that any failures in
dependency-graph generation or submission were logged as warnings, but
did not cause the workflow to fail.

However, in some cases the primary purpose of a workflow is to generate
and submit a dependency graph: in these cases it is desirable to have
the workflow fail when this process breaks.

This PR introduces a new `dependency-graph-continue-on-failure`
parameter, which when `false` will enable the latter behaviour. It also
adds test coverage for different failures in dependency graph generation
and submission.

Fixes #1034 
Fixes #997
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant