-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgraded Gradle Wrapper to 8.1.1 #94
Conversation
Hey @nulls, thank you for the PR. Is this something you need included or just build hygene? Asking because I'm considering moving the plugin to https://github.com/gradlex-org and that would include kind of a rewrite anyways. |
@nulls okay, I see. I'll have a look into this on the weekend. Unfortunately I think we need to do this differently in order to keep compatibility with released versions. |
@nulls sorry to keep you waiting. This is next on my backlog. I hope to find some time the coming week to merge and release this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nulls! Finally got to reviewing this. I think the problem are not the types of the inputs but their annotations. Can you please try if changing them the way I've pointed out makes it work on Gradle 8? That way we can leave the types as they are and don't break binary compat.
...kotlin/de/benediktritter/maven/plugin/development/task/AbstractMavenPluginDevelopmentTask.kt
Outdated
Show resolved
Hide resolved
.../kotlin/de/benediktritter/maven/plugin/development/task/GenerateMavenPluginDescriptorTask.kt
Outdated
Show resolved
Hide resolved
.../kotlin/de/benediktritter/maven/plugin/development/task/GenerateMavenPluginDescriptorTask.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
@nulls I've released 0.4.2 which contains your fix. Please give it a try! |
Thanks, now it does work! |
What's done:
:plugin:stutterWriteLocks
It closes #91