Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgraded Gradle Wrapper to 8.1.1 #94

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

nulls
Copy link
Contributor

@nulls nulls commented May 3, 2023

What's done:

  • updated gradle wrapper
  • supported changes in build.gradle.kts
  • updated java8.lock by :plugin:stutterWriteLocks
  • changed input parameters for tasks, because Gradle 8.x cannot serialize FileCollection and Configuration

It closes #91

@nulls nulls marked this pull request as ready for review May 3, 2023 11:33
@britter
Copy link
Member

britter commented May 5, 2023

Hey @nulls, thank you for the PR. Is this something you need included or just build hygene? Asking because I'm considering moving the plugin to https://github.com/gradlex-org and that would include kind of a rewrite anyways.

@nulls
Copy link
Contributor Author

nulls commented May 5, 2023

Hi @britter,
Our project diktat uses this plugin and we are upgrading the Gradle version in the project.
It would be great if it will be included.

Btw, I see that Sample Project Build does fail. I guess it's okay till a new version is released, isn't it?

@britter
Copy link
Member

britter commented May 8, 2023

@nulls okay, I see. I'll have a look into this on the weekend. Unfortunately I think we need to do this differently in order to keep compatibility with released versions.

@britter
Copy link
Member

britter commented May 21, 2023

@nulls sorry to keep you waiting. This is next on my backlog. I hope to find some time the coming week to merge and release this.

Copy link
Member

@britter britter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nulls! Finally got to reviewing this. I think the problem are not the types of the inputs but their annotations. Can you please try if changing them the way I've pointed out makes it work on Gradle 8? That way we can leave the types as they are and don't break binary compat.

Copy link
Member

@britter britter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@britter britter merged commit 90d0efd into gradlex-org:main Jun 5, 2023
@britter
Copy link
Member

britter commented Jun 5, 2023

@nulls I've released 0.4.2 which contains your fix. Please give it a try!

@britter britter modified the milestone: 0.4.2 Jun 5, 2023
@nulls nulls deleted the feature/gradle-8.x branch June 6, 2023 07:46
@nulls
Copy link
Contributor Author

nulls commented Jun 6, 2023

@nulls I've released 0.4.2 which contains your fix. Please give it a try!

Thanks, now it does work!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle 8.0 compatibility
2 participants