Mitigate errors when receiving requests with empty HTTP request bodies #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ echo "" | http localhost:3003 Content-Type:application/json HTTP/1.0 400 BAD REQUEST <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN"> <title>400 Bad Request</title> <h1>Bad Request</h1> <p>Failed to decode JSON object: Expecting value: line 1 column 1 (char 0)</p>
This was referenced Feb 4, 2022
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
at #9 (comment), we discovered that there is an issue with Simple JSON Datasource sending HTTP requests with empty HTTP request bodies, but still having the
Content-Type: application/jsonHTTP header present. Those requests will make Flask croak like:This patch fixes the problem, like @ThiefMaster suggested at pallets/flask#1940 (comment):
In this manner, it will also resolve #7.
With kind regards,
Andreas.
/cc @byteptr, @MichielKE