Add a snmp_context argument to SNMP exporter #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbaranowski
approved these changes
May 22, 2024
clayton-cornell
approved these changes
May 23, 2024
There was a problem hiding this comment.
Doc changes look OK to me. @erikbaranowski are good to go for a merge?
ptodev
force-pushed
the
ptodev/add-snmp_context
branch
from
5901816 to
2a92db4
Compare
erikbaranowski
added a commit
that referenced
this pull request
May 31, 2024
* Update pyroscope/ebpf to v0.4.6 (#678) (#6917) * Update pyroscope/ebpf to v0.4.4 Note: Pyroscope updated its prometheus/common dependecy and hence this required further updates. * Also update windows exporter * Allow pid maps to be configured This also modifieds the way we do defaulting and valides those two new fields. * Update pyroscope/ebpf v0.4.5 This updates the pyroscope/ebpf annotations to both have alloy and river ones. * Add some testing for argument validation * Update to v0.4.6 to fix debug data This also includes a test to make sure debug data is marshalled correctly. Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Add a snmp_context argument (#6923) * Update `make docs` procedure (#6930) Co-authored-by: grafanabot <bot@grafana.com> --------- Co-authored-by: Christian Simon <simon@swine.de> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> Co-authored-by: Paulin Todev <paulin.todev@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: grafanabot <bot@grafana.com>
4 tasks
github-actions
bot
added
the
frozen-due-to-age
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds a new config argument which was added to upstream recently
Notes to the Reviewer
I still haven't tested this. I hope to test it tomorrow with some help from @bastischubert
PR Checklist