Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update SNMP exporter #762

Merged
merged 1 commit into from
May 14, 2024
Merged

Update SNMP exporter #762

merged 1 commit into from
May 14, 2024

Conversation

ptodev
Copy link
Collaborator

@ptodev ptodev commented May 3, 2024

This PR will pick up a particular feature from the upstream SNMP exporter.

Unfortunately, this feature is not yet in a "release" version of SNMP exporter. If @RichiH is planning to release a new version soon, then I could change the go.mod to reference it? If there isn't a new version, then we'll need to reword our docs to point to the commit.

@ptodev ptodev force-pushed the ptodev/update-snmp-exporter branch from 997af80 to 79c49b9 Compare May 13, 2024 17:21
@ptodev ptodev marked this pull request as ready for review May 13, 2024 17:21
@ptodev ptodev requested a review from clayton-cornell as a code owner May 13, 2024 17:21
@ptodev ptodev force-pushed the ptodev/update-snmp-exporter branch from 79c49b9 to cb118e5 Compare May 13, 2024 17:22
@ptodev ptodev added the backport-to-agent PR should be backported to the agent repo. label May 13, 2024
@ptodev ptodev force-pushed the ptodev/update-snmp-exporter branch 2 times, most recently from 6e3967a to 9b64b81 Compare May 14, 2024 14:12
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a small comment on the changelog

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 14, 2024
@ptodev ptodev force-pushed the ptodev/update-snmp-exporter branch from 9b64b81 to 15271b5 Compare May 14, 2024 16:02
@ptodev ptodev merged commit f377891 into main May 14, 2024
18 checks passed
@ptodev ptodev deleted the ptodev/update-snmp-exporter branch May 14, 2024 16:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport-to-agent PR should be backported to the agent repo. frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants