Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(generator): trim group name for CompositeResourceDefinitions #16

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

Duologic
Copy link
Member

@Duologic Duologic commented Dec 18, 2024

XRD metadata.name consists of plural+group, for some resources this became longer than 63 characters, which resulted in this error:

'cannot establish control of object: Composition.apiextensions.crossplane.io "stackserviceaccounttoken-namespaced" is invalid: metadata.labels: Invalid value:"xstackserviceaccounttokens.cloud.grafana.crossplane.io.namespaced": must be no more than 63 characters'

This PR replaces part of the group name: s/crossplane.io/net to trim of a few characters.

For review: first commit is the manual change, second has the generated files.

@Duologic Duologic requested a review from a team as a code owner December 18, 2024 10:32
Copy link

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

how was commit #2 generated? I couldn't find this in the docs 🤔

@Duologic
Copy link
Member Author

make build, this is also run from the CI to identify if everything is in sync.

@Duologic Duologic merged commit 493b1f1 into main Dec 20, 2024
2 checks passed
@Duologic Duologic deleted the duologic/trim_long_group branch December 20, 2024 11:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants