Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[tempo] Revert "Merge pull request #3404 from farcaller/patch-1" #3470

Closed
wants to merge 3 commits into from

Conversation

Sheikh-Abubaker
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker commented Dec 7, 2024

Fixes #3417

The PR simply reverts the changes made by #3404 which introduced a breaking change for tempoQuery .

Signed-off-by: Sheikh-Abubaker <sheikhabubaker761@gmail.com>
@Sheikh-Abubaker Sheikh-Abubaker changed the title [tempo] Revert tempo app version to 2.5.0 [tempo] Revert "Merge pull request #3404 from farcaller/patch-1" Dec 7, 2024
@Sheikh-Abubaker Sheikh-Abubaker added help wanted Extra attention is needed bug Something isn't working labels Dec 7, 2024
Signed-off-by: Sheikh-Abubaker <sheikhabubaker761@gmail.com>
@zalegrala
Copy link
Contributor

If this is just a version and docs change, perhaps we roll forward? What do you think?

@Sheikh-Abubaker
Copy link
Collaborator Author

If this is just a version and docs change, perhaps we roll forward? What do you think?

@zalegrala sure!

@zanhsieh
Copy link
Collaborator

@Sheikh-Abubaker I close this PR since you and @zalegrala agreed to roll forward. In case my understanding incorrectly, please reopen this PR.

@zanhsieh zanhsieh closed this Dec 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking: TempoQuery Startup
3 participants