Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[grafana] feat(pvc): support annotations in StatefulSet volumeClaimTemplate #3311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[grafana] feat(pvc): support annotations in StatefulSet volumeClaimTemplate #3311

wants to merge 3 commits into from
+5 −1

Conversation

kirgene
Copy link

@kirgene kirgene commented Sep 14, 2024

This PR adds persistence PVC annotations to grafana StatefulSet volumeClaimTemplate.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kirgene
[grafana] feat(pvc): support pvc annotations in StatefulSet
5dada40 
Signed-off-by: Yevhen Kyriukha <kirgene@gmail.com>
@zanhsieh
Update Chart.yaml
cc7d529 
Signed-off-by: MH <zanhsieh@gmail.com>

Signed-off-by: MH <zanhsieh@gmail.com>
jkroepke
jkroepke reviewed Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency: Should labels and finalizer supported as well?

https://github.com/kirgene/helm-charts/blob/cc7d529facefb4b6f5eeeb7304d4167fdb4999d1/charts/grafana/templates/pvc.yaml#L7-L19

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jkroepke jkroepke jkroepke left review comments

@zanhsieh zanhsieh zanhsieh approved these changes

@maorfr maorfr Awaiting requested review from maorfr maorfr is a code owner

@torstenwalter torstenwalter Awaiting requested review from torstenwalter torstenwalter is a code owner

@Xtigyro Xtigyro Awaiting requested review from Xtigyro Xtigyro is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirgene @CLAassistant @zanhsieh @jkroepke