[tempo] LoadBalancer cannot simultaneously support TCP and UDP protocols #3317
+114
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Costis <ccostis@gmail.com>
CostisC
requested review from
Sheikh-Abubaker,
dgzlopes,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
CostisC
changed the title
There was a problem hiding this comment.
Hey there! @CostisC could you please address the failed CI checks ? Thank you!
Signed-off-by: Costis <ccostis@gmail.com>
CostisC
force-pushed
the
nlb-protocols
branch
from
cbaf5a2
to
8c379b0
Compare
|
Thank you, @Sheikh-Abubaker! |
Signed-off-by: Costis <ccostis@gmail.com>
|
Hi @Sheikh-Abubaker. There seems to have been an env. setup failure. Could you please have a look. Cheers! |
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Nov 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Network Load Balancers (e.g. in GKE) cannot support UDP and TCP at the same time.
This enhancement adds the
service.protocoloption that defines which L4 protocols to be exposed.Further, it will set the exposed ports according to the relevant
tempo.receiversvalues.