-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[tempo-operator]: Adds first implementation of tempo-operator helm-chart #3329
Open
suyash-811
wants to merge
21
commits into
grafana:main
Choose a base branch
from
suyash-811:feat/create-tempo-operator-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[tempo-operator]: Adds first implementation of tempo-operator helm-chart #3329
suyash-811
wants to merge
21
commits into
grafana:main
from
suyash-811:feat/create-tempo-operator-chart
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suyash Sonawane <sonawsuyash@proton.me> Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash Sonawane <sonawsuyash@proton.me> Signed-off-by: Suyash S <sonawsuyash@proton.me>
…f-signed-issuer manifest. Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
…cified Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: Suyash S <sonawsuyash@proton.me>
suyash-811
force-pushed
the
feat/create-tempo-operator-chart
branch
from
September 25, 2024 22:10
2868fd8
to
644f8e2
Compare
Signed-off-by: Suyash S <sonawsuyash@proton.me>
Signed-off-by: William Dumont <william.dumont@grafana.com> Signed-off-by: Suyash S <sonawsuyash@proton.me>
suyash-811
force-pushed
the
feat/create-tempo-operator-chart
branch
from
September 26, 2024 20:37
e39630c
to
369a783
Compare
I pushed a commit to fix problems with linting, but pushed without the signoff. Thus, had to rebase with a signoff again. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
We were expressing interest in #3032 to create a helm-chart for tempo-operator. I started working on this a while ago, and i have an initial working version of the helm-chart.
I would however like to also get some help on certain open questions, which could help maintaining this chart easier in the future. (Questions listed below)
CRDs
? I have included them in thecrds
folder in the chart. However, often migrating to newer versions of the CRDs could be challenging. Any ideas on how to handleCRDs
?Looking forward to suggestions for improvements and collaborating on bringing this to release soon! 😄
(P.S. apologies if i missed out any details. This is my first PR here.)