[tempo] Add ability to set persistentVolumeClaimRetentionPolicy in Tempo StatefulSet
#3353
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerfio
force-pushed
the
aerfio/tempo-enableStatefulSetAutoDeletePVC
branch
from
920eb35
to
5febc86
Compare
Signed-off-by: Mateusz Puczyński <mati6095@gmail.com>
aerfio
force-pushed
the
aerfio/tempo-enableStatefulSetAutoDeletePVC
branch
from
5febc86
to
83365ca
Compare
aerfio
requested review from
Sheikh-Abubaker,
dgzlopes,
swartz-k,
BitProcessor and
faustodavid
as code owners
Signed-off-by: Mateusz Puczyński <mati6095@gmail.com>
aerfio
force-pushed
the
aerfio/tempo-enableStatefulSetAutoDeletePVC
branch
from
477a8da
to
ea0c4c8
Compare
|
Hi @Sheikh-Abubaker, I see that you're reviewing other PRs, could you please take a look at this one? Thank you in advance 😄 |
Hey @aerfio sorry for the delay, I'm a bit occupied as of now, but will review it soon! |
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Nov 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to set
persistentVolumeClaimRetentionPolicylike in other charts:helm-charts/charts/loki-distributed/templates/compactor/statefulset-compactor.yaml
Line 24 in 83365ca
helm-charts/charts/loki-distributed/templates/index-gateway/statefulset-index-gateway.yaml
Line 24 in 83365ca
helm-charts/charts/loki-distributed/templates/ingester/statefulset-ingester.yaml
Line 29 in 83365ca
I can also expose the ability to override
if requested.