Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[rollout-operator] make relabelings optional for rollout operator #3376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukas-unity
Copy link
Contributor

Rollout operator always creates relabelings when serviceMonitor is enabled, which produces invalid yaml

# Source: rollout-operator/templates/servicemonitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: release-name-rollout-operator
  labels:
    helm.sh/chart: rollout-operator-0.18.1
    app.kubernetes.io/name: rollout-operator
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v0.19.1"
    app.kubernetes.io/managed-by: Helm
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: rollout-operator
      app.kubernetes.io/instance: release-name
  endpoints:
    - port: http-metrics
      relabelings:  < --- here
      scheme: http

Signed-off-by: Lukas Monkevicius <lukas.monkevicius@unity3d.com>
@lukas-unity lukas-unity changed the title make relabelings optional for rollout operator [rollout-operator] make relabelings optional for rollout operator Oct 25, 2024
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants