managed-by is set at install time by the managing installer, and should not be templated.
#3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould not be templated. Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
requested review from
torstenwalter,
zanhsieh,
Whyeasy,
dgzlopes,
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid,
unguiculus,
jkroepke,
maorfr,
Xtigyro and
a team
as code owners
|
|
|
Hi @bleggett thanks for you request. Please create a dedicated PR for each chart and increase the version separately. |
This was referenced Nov 4, 2024
Open
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app.kubernetes.io/managed-by: Helmis automatically applied to resources installed by Helm viahelm install, and does not need to be (read: should not be) manually templated. The label is an install-time label that should be applied by the tool actually installing the resources into the cluster.This matters because
helm templateshould (and by default will) produce YAML without this label, as it is unknown at template-time what will "manage" the resource - e.g.helm template | kubectl apply -f -should not produce resources with theapp.kubernetes.io/managed-by: Helmlabel, because the resources are not managed by helm.xref: istio/istio#53698