[synthetic-monitoring-agent] remove references to HPA or multiple replicas #3402
+3
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
force-pushed
the
sm-agent-remove-hpa
branch
2 times, most recently
from
9455114
to
22802f5
Compare
roobre
changed the title
roobre
force-pushed
the
sm-agent-remove-hpa
branch
from
22802f5
to
5273335
Compare
roobre
changed the title
…icas Signed-off-by: Nadia Santalla <nadia@santalla.io>
roobre
force-pushed
the
sm-agent-remove-hpa
branch
from
5273335
to
6058ce9
Compare
zanhsieh
approved these changes
Nov 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SM agent does not support running as multiple instances. Despite being part of the default
helm createboilerplate, the presence ofreplicasinvalues.yamland the HPA object in the templates can lead users to believe it is possible to do this, or attempt it.This PR gets rid of those components to avoid the confusion.