Add missing browser request docs #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
commented
Jun 3, 2024
Comment on lines
28
to
29
| | <a href="https://playwright.dev/docs/api/class-request#request-redirected-to" target="_blank" >request.redirectedTo()</a> | - | | ||
| | <a href="https://playwright.dev/docs/api/class-request#request-resource-type" target="_blank" >request.resourceType()</a> | - | |
There was a problem hiding this comment.
These are not defined in k6 browser.
ankur22
force-pushed
the
async/browser-request
branch
from
7d940d0 to
eb65da6
Compare
ankur22
force-pushed
the
async/browser-request
branch
from
3662b00 to
7d22b94
Compare
inancgumus
approved these changes
Jun 3, 2024
docs/sources/next/javascript-api/k6-experimental/browser/request/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/allheaders.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/allheaders.md
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/headersarray.md
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/headersarray.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/resourcetype.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/timing.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/timing.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/request/allheaders.md
Show resolved
Hide resolved
Since we're in the context of resource type, we don't need to reference it as resourceType.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add missing browser request docs. Also ensure that the existing docs use the correct async request methods.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.Related PR(s)/Issue(s)
grafana/xk6-browser#1308