Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Warn the user that using -i/-u/-d will overwrite everything about their scenarios #2529

Closed
mstoykov opened this issue May 12, 2022 · 0 comments · Fixed by #4176
Closed

Warn the user that using -i/-u/-d will overwrite everything about their scenarios #2529

mstoykov opened this issue May 12, 2022 · 0 comments · Fixed by #4176

Comments

@mstoykov
Copy link
Contributor

mstoykov commented May 12, 2022

Feature Description

Users are sometimes confused why using -i, -u or/and -d works the way it does. This includes both why does it suddenly not use their exec function or why they don't use the env they have defined.

While there are some indications that we no longer run the same scenarios, it likely will be nice to be more explicit.

p.s. forgot about -s for stages, as I never see it used 🤦

Suggested Solution (optional)

On usage of any of the shortcut options - print a warning stating that this will completely overwrite the whole options.scenarios possibly somewhere in

func DeriveScenariosFromShortcuts(opts lib.Options, logger logrus.FieldLogger) (lib.Options, error) {

Already existing or connected issues / PRs (optional)

No response

mstoykov added a commit that referenced this issue Jan 14, 2025
This is currently implemented only for scenarios as that is the case
that is most confusing. Implementing this for duration overriding stages
(for example) is possible, but it seems to not be nearly hit enough.

Unfortunately due to too many of things of #883 and the way shorthand
options are handled in particular, the code can't be in any Apply
function with enough information to have a nice message.

Fixes #2529
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant