Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Assign pull-requests via CODEOWNERS #3489

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Assign pull-requests via CODEOWNERS #3489

merged 1 commit into from
Dec 18, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Dec 5, 2023

What?

This changes the pull-request assignment from an in-house script/workflow to a CODEOWNERS file. The issues remain with the script/workflow since, at the moment of the change, CODEOWNERS still needs to support the issues balancing/assignment.

Why?

CODEOWNERS is more maintainable and provides other excellent features, like considering "busy" status.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfdc446) 73.21% compared to head (11de1cc) 73.21%.

❗ Current head 11de1cc differs from pull request most recent head 8a88695. Consider uploading reports for the commit 8a88695 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3489   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         267      267           
  Lines       20083    20083           
=======================================
  Hits        14704    14704           
  Misses       4465     4465           
  Partials      914      914           
Flag Coverage Δ
ubuntu 73.15% <ø> (-0.01%) ⬇️
windows 73.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien merged commit 001aff5 into master Dec 18, 2023
21 checks passed
@codebien codebien deleted the feat/codeowners branch December 18, 2023 09:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants