Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update grpc #3502

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Update grpc #3502

merged 2 commits into from
Dec 15, 2023

Conversation

mstoykov
Copy link
Contributor

What?

Update gRPC dependencies

Why?

They are done separately as they sometimes have breaking changes - not this time it seems :)

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.49.0 milestone Dec 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa0e221) 73.20% compared to head (18ba383) 73.19%.
Report is 4 commits behind head on master.

❗ Current head 18ba383 differs from pull request most recent head 0478f59. Consider uploading reports for the commit 0478f59 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3502      +/-   ##
==========================================
- Coverage   73.20%   73.19%   -0.01%     
==========================================
  Files         267      267              
  Lines       20076    20076              
==========================================
- Hits        14696    14694       -2     
- Misses       4466     4468       +2     
  Partials      914      914              
Flag Coverage Δ
ubuntu 73.12% <ø> (-0.03%) ⬇️
windows 73.03% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joanlopez
joanlopez previously approved these changes Dec 14, 2023
Base automatically changed from updateDependancies to master December 14, 2023 14:32
@mstoykov mstoykov dismissed joanlopez’s stale review December 14, 2023 14:32

The base branch was changed.

@olegbespalov olegbespalov added the dependencies Pull requests that update a dependency file label Dec 15, 2023
@mstoykov mstoykov merged commit 6490bc4 into master Dec 15, 2023
20 checks passed
@mstoykov mstoykov deleted the updateGRPC branch December 15, 2023 13:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants