Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Completely remove experimental GRPC module #3530

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jan 11, 2024

What?

This change completely removes the experimental GRPC module, as it was announced in #3490

Why?

The same functionality is in k6-core, and we waited for several releases.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3490

@olegbespalov olegbespalov added this to the v0.51.0 milestone Jan 11, 2024
@olegbespalov olegbespalov force-pushed the feat/remove-experimental-grpc branch from 44bbbd4 to f048a27 Compare January 11, 2024 12:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.64%. Comparing base (b80ad9f) to head (76e1cc8).

❗ Current head 76e1cc8 differs from pull request most recent head 25d12ad. Consider uploading reports for the commit 25d12ad to get more accurate results

Files Patch % Lines
js/jsmodules.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3530      +/-   ##
==========================================
+ Coverage   73.62%   73.64%   +0.02%     
==========================================
  Files         277      277              
  Lines       20243    20240       -3     
==========================================
+ Hits        14904    14906       +2     
+ Misses       4394     4390       -4     
+ Partials      945      944       -1     
Flag Coverage Δ
macos 73.56% <71.42%> (?)
ubuntu 73.59% <71.42%> (+0.03%) ⬆️
windows 73.48% <71.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov self-assigned this Jan 11, 2024
@olegbespalov olegbespalov added maintenance breaking change for PRs that need to be mentioned in the breaking changes section of the release notes area: grpc documentation-needed A PR which will need a separate PR for documentation labels Jan 11, 2024
@olegbespalov olegbespalov force-pushed the feat/remove-experimental-grpc branch from f048a27 to 4da2f65 Compare April 4, 2024 09:52
@olegbespalov olegbespalov marked this pull request as ready for review April 4, 2024 09:53
@olegbespalov olegbespalov requested a review from a team as a code owner April 4, 2024 09:53
@olegbespalov olegbespalov requested review from codebien and joanlopez and removed request for a team April 4, 2024 09:53
js/jsmodules.go Outdated Show resolved Hide resolved
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@olegbespalov olegbespalov requested a review from codebien April 4, 2024 11:31
@olegbespalov olegbespalov merged commit 443528d into master Apr 4, 2024
25 checks passed
@olegbespalov olegbespalov deleted the feat/remove-experimental-grpc branch April 4, 2024 12:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: grpc breaking change for PRs that need to be mentioned in the breaking changes section of the release notes documentation-needed A PR which will need a separate PR for documentation maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants