Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removes statsd output #3849

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Removes statsd output #3849

merged 2 commits into from
Oct 15, 2024

Conversation

olegbespalov
Copy link
Contributor

What?

Removes StatsD output from k6 in favor of https://github.com/LeonAdato/xk6-output-statsd

Why?

An external extension exists https://github.com/LeonAdato/xk6-output-statsd.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3848

Closes #2982

@olegbespalov olegbespalov added breaking change for PRs that need to be mentioned in the breaking changes section of the release notes documentation-needed A PR which will need a separate PR for documentation dependencies Pull requests that update a dependency file metrics-output labels Jul 15, 2024
@olegbespalov olegbespalov added this to the v0.55.0 milestone Jul 15, 2024
@olegbespalov olegbespalov self-assigned this Jul 15, 2024
@olegbespalov olegbespalov marked this pull request as ready for review October 11, 2024 06:57
@olegbespalov olegbespalov requested a review from a team as a code owner October 11, 2024 06:57
@olegbespalov olegbespalov requested review from mstoykov and joanlopez and removed request for a team October 11, 2024 06:57
mstoykov
mstoykov previously approved these changes Oct 11, 2024
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But am not certain what is going on with windows packaging

@joanlopez
Copy link
Contributor

But am not certain what is going on with windows packaging

Looks like it was a temporary error, something wrong with the NuGet backend made it impossible to download & install one of the dependencies we use for packaging:

[NuGet] Response status code does not indicate success: 503 (Service Unavailable: Back-end server is at capacity).

I just clicked on retry, and it worked now. Apparently they managed whatever was wrong with their backend.

joanlopez
joanlopez previously approved these changes Oct 11, 2024
Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the tiny typo, it looks good! 🎉

Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>
@olegbespalov olegbespalov dismissed stale reviews from joanlopez and mstoykov via fb28fb2 October 11, 2024 11:12
@olegbespalov olegbespalov merged commit d96edbc into master Oct 15, 2024
21 of 22 checks passed
@olegbespalov olegbespalov deleted the feat/remove-statsd branch October 15, 2024 11:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes dependencies Pull requests that update a dependency file documentation-needed A PR which will need a separate PR for documentation
Projects
Development

Successfully merging this pull request may close these issues.

Future of StatsD outputs
3 participants