Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Sobek: numeric literal separators #3925

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Update Sobek: numeric literal separators #3925

merged 2 commits into from
Aug 29, 2024

Conversation

joanlopez
Copy link
Contributor

@joanlopez joanlopez commented Aug 29, 2024

What?

It updates Sobek to the latest version.

Why?

It adds support for numeric literal separators: grafana/sobek#23

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

grafana/sobek#23

@joanlopez joanlopez self-assigned this Aug 29, 2024
@joanlopez joanlopez requested a review from a team as a code owner August 29, 2024 08:59
@joanlopez joanlopez requested review from mstoykov and olegbespalov and removed request for a team August 29, 2024 08:59
mstoykov
mstoykov previously approved these changes Aug 29, 2024
@mstoykov mstoykov added this to the v0.54.0 milestone Aug 29, 2024
@joanlopez joanlopez force-pushed the update-sobek branch 2 times, most recently from 15cae1d to ab922c5 Compare August 29, 2024 09:57
@joanlopez joanlopez merged commit cd08078 into master Aug 29, 2024
22 of 23 checks passed
@joanlopez joanlopez deleted the update-sobek branch August 29, 2024 14:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants