Add testutils.MakeMemMapFs test helper #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on another PR I was looking for a way to quickly initialize a test Fs. I found in the codebase occurences of a makeMemMapFs function, which was already duplicated twice in the codebase. Instead of adding a third copy, I thought I would instead make testutil out of it. This is exactly what this commit does.
oleiade
requested review from
mstoykov and
joanlopez
and removed request for
a team
joanlopez
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Looks good to me, the only question I have is: now that we're planning v1.0, do we really want to expose it under: /lib/..., or should we (at least first) add it internally? 🤔 Although, it's also true that it might be useful for writing some extensions tests.
Let's see what others say.
mstoykov
approved these changes
Sep 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a small refactoring and low priority, review it when you have capacity, no rush 🙇🏻
This PR introduces a
MakeMemMapFstest helper to the testutils package.This helper function creates a new in-memory filesystem with the given files. It is particularly useful for testing code that interacts with the filesystem, as it allows the creation of a filesystem with a known state without having to create temporary directories and files on disk.
Why?
While working on another PR, I was looking for a way to initialize a test Fs quickly. I found in the codebase occurences of a
makeMemMapFsfunction, which was already duplicated twice in the codebase.In the spirit of continuous improvement, instead of adding a third copy, I thought I would make a
testutilfunction out of it.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)