Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adjusts recommendations for check #4043

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

olegbespalov
Copy link
Contributor

What?

This address @heitortsergent feedback from the:

Why?

Feedback proposes a better texting which is better for end-users

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#4037

@olegbespalov olegbespalov self-assigned this Nov 8, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner November 8, 2024 07:21
@olegbespalov olegbespalov requested review from inancgumus and ankur22 and removed request for a team November 8, 2024 07:21
@olegbespalov olegbespalov requested a review from mstoykov November 8, 2024 08:24
@olegbespalov
Copy link
Contributor Author

@mstoykov adding you keeping in mind that you commented #4037 (comment), feel free to suggest the texting if you feel that we need to adjust it

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@olegbespalov olegbespalov added this to the v0.55.0 milestone Nov 8, 2024
@olegbespalov olegbespalov merged commit 0411e28 into master Nov 8, 2024
22 of 23 checks passed
@olegbespalov olegbespalov deleted the chore/check-async-warn-feedback branch November 8, 2024 10:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants