Windows test go tip under carpet #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
ankur22 and
joanlopez
and removed request for
a team
ankur22
approved these changes
Dec 11, 2024
olegbespalov
approved these changes
Dec 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Get github actions to not be broken on windows gotip
Why?
Not having CI red is good.
I tried to actually fix the issue but can't reproduce it locally on windows VM and it doesn't seem anything I tried made a difference in github actions. So for now just disabling the test.
I also bumped to use latest windows as a thing that we probably should've done long ago. My testing hasn't shown it being more flaky so 🤷
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)