Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

streams: just use modulestest to get setTimeout and co. #4189

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Jan 16, 2025

What?

Use modulesTest insead of k6/timers module

Why?

This breaks in some cases and more importantly isn't really necessary

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.57.0 milestone Jan 16, 2025
@mstoykov mstoykov requested a review from a team as a code owner January 16, 2025 15:26
@mstoykov mstoykov requested review from olegbespalov and joanlopez and removed request for a team January 16, 2025 15:26
Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @mstoykov! I wasn't aware of this when I worked on streams, so I'm learning on the way, thanks for sharing! :)

@mstoykov
Copy link
Contributor Author

There is a good chance this was added after the streams work.

@joanlopez
Copy link
Contributor

There is a good chance this was added after the streams work.

Anyway, the same applies, thanks for improving what exists, and sharing it (if I have seen this before, I completely forgot, I hope I'll remind it next time I need something similar).

💟

@mstoykov mstoykov merged commit 82457c2 into master Jan 16, 2025
29 checks passed
@mstoykov mstoykov deleted the fixReadableStreamsTest branch January 16, 2025 16:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants