Various improvements to unit tests. #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomwilkie
commented
May 8, 2019
tomwilkie
commented
- Stop ingester tests from taking 60s, by setting Cortex shutdown wait period to 0 (its theres to allow one final scrape of metrics in production)
- Listen on localhost in promtail tests, to prevent dialog warning on MacOS (probably cause of TestPromtail is flaky #558)
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
|
Depends on weaveworks/common#153, but happy to merge this as we're using my branch for now. |
gouthamve
approved these changes
May 8, 2019
|
Cool. |
|
I'll flip back to upstream once that PR is merged. WW usually merge them; I'm the main contributor to it :-) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.