Alertmanager: Initialize skipped Grafana Alertmanagers receiving requests #10691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview available: https://deploy-preview-mimir-10691-zb444pucvq-vp.a.run.app/docs/mimir/latest/ |
santihernandezc
commented
Feb 20, 2025
| @@ -104,7 +104,6 @@ type Config struct { | |||
| PersisterConfig PersisterConfig | |||
|
|
|||
| GrafanaAlertmanagerCompatibility bool | |||
| GrafanaAlertmanagerTenantSuffix string | |||
There was a problem hiding this comment.
Unrelated fix, this was not being used here.
santihernandezc
changed the title
tacole02
approved these changes
Feb 21, 2025
…mestamp for tenants not yet in the receivingRequests map
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
grafana_alertmanager_conditionally_skip_tenant_suffixoption is configured and a Grafana Alertmanager tenant doesn't have a promoted, non-default, non-empty configuration, we skip initializing it.The problem is that clients making requests against an uninitialized Alertmanager get
406s. Unless a Grafana Alertmanager has a "usable" configuration, users won't be able to test templates, test and get receivers, create silences, etc.This PR makes the multi-tenant Alertmanager start per-tenant Grafana Alertmanagers on incoming requests. This way, requests can be handled even if tenants were initially skipped.
It also adds a grace period for idle Alertmanagers. Whenever a skipped Alertmanager gets a request, we start the Alertmanager and keep a timestamp indicating when this request was received. After the grace period elapses, we shut down the Alertmanager.
Testing
I tested this PR by spinning up two Alertmanagers (read-write mode) with:
multitenancy_enabled: truegrafana_alertmanager_compatibility_enabled: truegrafana_alertmanager_conditionally_skip_tenant_suffix: -grafanaI then created 200 Alertmanager tenants with empty configurations:
The 99 tenants with empty configuration and matching the suffix were initially skipped. I then sent test alerts for each tenant matching the suffix. Alertmanagers for each of them were started.
After the default grace period passed, all Alertmanagers for tenants matching the configured suffix were stopped, except the one using a promoted, non-default, non-empty configuration.
Query for tenants skipped per instance
Query for active Alertmanagers by type (Mimir/Grafana)