Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: update missing users / empty shifts check #5322

Merged
merged 3 commits into from
Jan 2, 2025
Merged

fix: update missing users / empty shifts check #5322

merged 3 commits into from
Jan 2, 2025

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Dec 3, 2024 •
edited
Loading

Related to https://github.com/grafana/irm/issues/885

  • Represent missing users in schedule events (so they are displayed in the web UI)
  • Fix schedule checks for gaps/empty shifts so they send notifications

@matiasb matiasb added pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes labels Dec 3, 2024
@matiasb matiasb force-pushed the matiasb/shifts-missing-users branch from 81394cb to 500b37d Compare December 6, 2024 14:26
@matiasb matiasb force-pushed the matiasb/shifts-missing-users branch from 500b37d to 9774289 Compare December 6, 2024 16:17
@matiasb matiasb force-pushed the matiasb/shifts-missing-users branch from 9774289 to a71ab68 Compare December 6, 2024 19:50
@matiasb matiasb force-pushed the matiasb/shifts-missing-users branch from a71ab68 to f8935bf Compare December 6, 2024 20:21
@matiasb matiasb marked this pull request as ready for review December 6, 2024 20:38
@matiasb matiasb requested a review from a team as a code owner December 6, 2024 20:38
@matiasb matiasb force-pushed the matiasb/shifts-missing-users branch from f8935bf to 28c2466 Compare December 17, 2024 11:49
@matiasb matiasb force-pushed the matiasb/shifts-missing-users branch from 28c2466 to c87ce35 Compare December 27, 2024 18:58
@matiasb matiasb force-pushed the matiasb/shifts-missing-users branch from c87ce35 to e602be2 Compare January 2, 2025 11:41
@matiasb matiasb added this pull request to the merge queue Jan 2, 2025
Merged via the queue into dev with commit f3f7c17 Jan 2, 2025
26 checks passed
@matiasb matiasb deleted the matiasb/shifts-missing-users branch January 2, 2025 14:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mderynck mderynck mderynck approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @mderynck